D13594: [WIP] Split SMS and Telephony plugin on desktop

[Simon Redman]

sredman added inline comments.

INLINE COMMENTS

> conversationsdbusinterface.h:94
>  
> -    TelephonyDbusInterface m_telephonyInterface;
> +    SmsDbusInterface m_telephonyInterface;
>  };

We should probably change the name of this variable too (for instance, to m_smsInterface)

> telephonyplugin.cpp:48-52
>      // FIXME: Same problem as discussed in the BatteryPlugin destructor and for the same reason:
>      // QtDbus does not allow us to delete m_conversationInterface. If we do so, we get a crash in the
>      // next DBus access to the parent
>  
>      //m_conversationInterface->deleteLater();

Needless to say, all of this can be removed since the telephony plugin no longer has a conversation interface

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D13594

To: nicolasfella, #kde_connect
Cc: sredman, kdeconnect, #kde_connect, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180619/4711c739/attachment-0001.html>