Review Request 127642: Remove second UDP socket in LanLinkProvider

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127642/#review94616
-----------------------------------------------------------



The patch is good, but as Aleix said it's better if we do this changes directly in the "sslrefactor" branch. I just checked it and we also have two sockets there.

Note we didn't merge that branch yet because it doesn't seem to work with Android older than 4.1, but we want to merge it soon: either by fixing the problem or by dropping support for older Androids. It will be awesome if you can test that branch. You will also need to compile the same branch for the Android app. If you have feedback or want to discuss it further, we can do it by email on the mailing list.

By the way, thanks for your recent patches!

- Albert Vaca Cintora


On abr. 13, 2016, 12:56 a.m., David Kahles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127642/
> -----------------------------------------------------------
> 
> (Updated abr. 13, 2016, 12:56 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> We don't need two sockets for reading and writing. I can't imagine the reason for this, sending and recieving should be possible from the same socket.
> 
> 
> Diffs
> -----
> 
>   core/backends/lan/lanlinkprovider.h 033877db97a3460387686881d9d89cec5139104f 
>   core/backends/lan/lanlinkprovider.cpp 03f429cf50ddf80e7f7a18ed45ea53731c118300 
> 
> Diff: https://git.reviewboard.kde.org/r/127642/diff/
> 
> 
> Testing
> -------
> 
> Device discovery, pairing and unpairing still works as before.
> 
> 
> Thanks,
> 
> David Kahles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160414/4d4ee777/attachment.html>