Review Request 127642: Remove second UDP socket in LanLinkProvider
David Kahles
david.kahles96 at gmail.com
Wed Apr 27 18:41:35 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127642/
-----------------------------------------------------------
(Updated April 27, 2016, 8:41 p.m.)
Status
------
This change has been discarded.
Review request for kdeconnect.
Repository: kdeconnect-kde
Description
-------
We don't need two sockets for reading and writing. I can't imagine the reason for this, sending and recieving should be possible from the same socket.
Diffs
-----
core/backends/lan/lanlinkprovider.h 033877db97a3460387686881d9d89cec5139104f
core/backends/lan/lanlinkprovider.cpp 03f429cf50ddf80e7f7a18ed45ea53731c118300
Diff: https://git.reviewboard.kde.org/r/127642/diff/
Testing
-------
Device discovery, pairing and unpairing still works as before.
Thanks,
David Kahles
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160427/f9c9ce9e/attachment.html>
More information about the KDEConnect
mailing list