<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127642/">https://git.reviewboard.kde.org/r/127642/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch is good, but as Aleix said it's better if we do this changes directly in the "sslrefactor" branch. I just checked it and we also have two sockets there.
Note we didn't merge that branch yet because it doesn't seem to work with Android older than 4.1, but we want to merge it soon: either by fixing the problem or by dropping support for older Androids. It will be awesome if you can test that branch. You will also need to compile the same branch for the Android app. If you have feedback or want to discuss it further, we can do it by email on the mailing list.
By the way, thanks for your recent patches!</pre>
<br />
<p>- Albert Vaca Cintora</p>
<br />
<p>On abril 13th, 2016, 12:56 a.m. PDT, David Kahles wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect.</div>
<div>By David Kahles.</div>
<p style="color: grey;"><i>Updated abr. 13, 2016, 12:56 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We don't need two sockets for reading and writing. I can't imagine the reason for this, sending and recieving should be possible from the same socket.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Device discovery, pairing and unpairing still works as before.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/backends/lan/lanlinkprovider.h <span style="color: grey">(033877db97a3460387686881d9d89cec5139104f)</span></li>
<li>core/backends/lan/lanlinkprovider.cpp <span style="color: grey">(03f429cf50ddf80e7f7a18ed45ea53731c118300)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127642/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>