Review Request 127642: Remove second UDP socket in LanLinkProvider

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127642/#review94576
-----------------------------------------------------------



The plan there is to adopt the `sslrefactor` branch. In fact it would be useful if you could give it a go.
I suggest not adding more differences in the network stack until we can adopt the forthcoming approach.

- Aleix Pol Gonzalez


On April 13, 2016, 9:56 a.m., David Kahles wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127642/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 9:56 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> We don't need two sockets for reading and writing. I can't imagine the reason for this, sending and recieving should be possible from the same socket.
> 
> 
> Diffs
> -----
> 
>   core/backends/lan/lanlinkprovider.h 033877db97a3460387686881d9d89cec5139104f 
>   core/backends/lan/lanlinkprovider.cpp 03f429cf50ddf80e7f7a18ed45ea53731c118300 
> 
> Diff: https://git.reviewboard.kde.org/r/127642/diff/
> 
> 
> Testing
> -------
> 
> Device discovery, pairing and unpairing still works as before.
> 
> 
> Thanks,
> 
> David Kahles
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20160413/2bcde372/attachment.html>