D6001: Ark: kerfuffle plugin Mac adaptation

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  > Re: "use QStandardPaths::findExecutable() to look for "otool"; I don't see why this would be required for otool and not ldd. Also, the otool command needs an additional argument. So we can either do a runtime lookup if the otool command exists (= we're on Mac) or we can test at compile time if we'll be running on Mac. I think the latter is the more appropriate approach.
  
  I prefer a runtime check, imho ifdefs should be used only when strictly necessary (= the code wouldn't compile otherwise). And yes, I'm ok if we look also for ldd through findExecutable().

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D6001

To: rjvbb, #ark, elvisangelaccio
Cc: elvisangelaccio, kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20170529/723a0b15/attachment.html>