Review Request: Ark must recognize a disk full error when extracting files using an external tool (bug 206383)

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5703/#review10309
-----------------------------------------------------------


While this is a first step towards fixing that bug report, I do feel that it still needs more work -- for one, this only works for cliinterface-derived plugins (ie. tar archives would still probably have that problem, for example).

The idea of detecting write errors when the programs write then is nice, and to me it sounds like it has more applications than just checking for "disk full" messages.

It would be interesting to check how libarchiveplugin and libsinglefileplugin currently behave under low disk space conditions, and perhaps use kdelibs' KDiskFreeSpaceInfo together with calculating the extracted size when possible to not even start the extraction when the disk will be full. 

- Raphael


On Nov. 1, 2010, 7:47 a.m., George  Metaxas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5703/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2010, 7:47 a.m.)
> 
> 
> Review request for kdeutils.
> 
> 
> Summary
> -------
> 
> Hello!
> This patch fixes bug 206383 in ark, where ark cannot handle the situation of a disk becoming full, when using an external extracting utility (rar, unrar, unzip, etc). 
> 
> 
> This addresses bug 206383.
>     https://bugs.kde.org/show_bug.cgi?id=206383
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeutils/ark/kerfuffle/cliinterface.h 1191233 
>   /trunk/KDE/kdeutils/ark/kerfuffle/cliinterface.cpp 1191233 
>   /trunk/KDE/kdeutils/ark/plugins/cli7zplugin/cliplugin.cpp 1191233 
>   /trunk/KDE/kdeutils/ark/plugins/cliplugin/cliplugin.cpp 1191233 
>   /trunk/KDE/kdeutils/ark/plugins/clirarplugin/cliplugin.cpp 1191233 
>   /trunk/KDE/kdeutils/ark/plugins/clizipplugin/cliplugin.cpp 1191233 
> 
> Diff: http://svn.reviewboard.kde.org/r/5703/diff
> 
> 
> Testing
> -------
> 
> Tested the code using a file mounted through loop in a local directory, and proceeding to extract into it archives with the following types:
> - A rar file
> - A 7z file
> - A zip file
> 
> 
> Thanks,
> 
> George
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-utils-devel/attachments/20110717/8ff913a2/attachment.htm