Review Request: Ark - "Add option to open-with, and also disable preview"

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6580/#review10310
-----------------------------------------------------------


Thanks, the patch looks really nice. I'm not really commenting on it yet because I'd like to discuss the general approach first. Using "Ctrl+W" doesn't sound very good (it's usually associated with closing tabs and things like that, plus it is not advertised anywhere), and changing the default behavior of the activated() signal will confuse the users. IMO, you should add a context menu with the options for opening with the default application and choosing the application from a list (and maybe the Preview option too). Besides that, there could be a new setting for choosing the default behavior when an item is selected.


/trunk/KDE/kdeutils/ark/part/part.cpp
<http://svn.reviewboard.kde.org/r/6580/#comment12013>

    You probably need manually remove the file here now that it is not removed in ArkViewer.



/trunk/KDE/kdeutils/ark/part/part.cpp
<http://svn.reviewboard.kde.org/r/6580/#comment12012>

    You need to pass true as the third parameter so the file is automatically removed later.


- Raphael


On March 4, 2011, 4:07 p.m., peter velthuis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6580/
> -----------------------------------------------------------
> 
> (Updated March 4, 2011, 4:07 p.m.)
> 
> 
> Review request for kdeutils.
> 
> 
> Summary
> -------
> 
> -double click/enter: opens with default viewer
> -'preview' button: opens the viewer like it does now.
> -ctrl+w: 'open with' dialog shows to choose the application to open with. (it's
> a KAction, but not added to a context menu or anything (yet)).
> 
> other:
> 
> QFile::remove calls removed and centralized in the destructor by deleting KTempDirs. 
> It creates a folder per opened file, same behaviour as winrar. Why?
> 
> The problem is that you dont know when an external program closes (started through KRun) so we cant remove the file directly after the external program closes. So with one directory this scenario will happen: open file, (temp dir created and file extracted therre), user closes file, opens again .. and the message "File already exists" appears. Probably this is also the first reason why the current preview dialog was created=> we know when the user closes it.
> 
> 
> This addresses bug 179066.
>     https://bugs.kde.org/show_bug.cgi?id=179066
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeutils/ark/part/arkviewer.cpp 1222951 
>   /trunk/KDE/kdeutils/ark/part/part.h 1222951 
>   /trunk/KDE/kdeutils/ark/part/part.cpp 1222951 
> 
> Diff: http://svn.reviewboard.kde.org/r/6580/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> peter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-utils-devel/attachments/20110717/23207935/attachment.htm