Review Request: Implement lha/lzh support in ark - Bug 231896

[Raphael Kubo da Costa]

> On July 17, 2011, 5:26 p.m., Raphael Kubo da Costa wrote:
> > Thanks for the patch, I hope you are still there :)
> > 
> > The patch looks fine overall, but the coding style is very inconsistent. In Ark we follow kdelibs' coding style, it might be good for you to take a look at it [1]. And please make sure there is no trailing whitespace in the code.
> > 
> > [1] http://techbase.kde.org/Policies/Kdelibs_Coding_Style

Oh, and I would be really happy if you could add some unit tests, at least for the list/extraction case. You could add a small sample file and use $KDEHOME (use KStandardDirs to get it) or a temporary directory as the extraction directory.


- Raphael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5761/#review10307
-----------------------------------------------------------


On Nov. 2, 2010, 2:22 p.m., George  Metaxas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5761/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2010, 2:22 p.m.)
> 
> 
> Review request for kdeutils.
> 
> 
> Summary
> -------
> 
> Implemented lzh/lha support in ark. Most of the required actions work file. However, the lha utility (http://lha.sourceforge.jp) does not like being used by another process. For example, if it has to overwrite a file, it simply skips it, when it is not being run at the terminal.  
> 
> 
> This addresses bug 231896.
>     https://bugs.kde.org/show_bug.cgi?id=231896
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeutils/ark/plugins/CMakeLists.txt 1191233 
>   /trunk/KDE/kdeutils/ark/plugins/clilhaplugin/CMakeLists.txt PRE-CREATION 
>   /trunk/KDE/kdeutils/ark/plugins/clilhaplugin/cliplugin.h PRE-CREATION 
>   /trunk/KDE/kdeutils/ark/plugins/clilhaplugin/cliplugin.cpp PRE-CREATION 
>   /trunk/KDE/kdeutils/ark/plugins/clilhaplugin/kerfuffle_clilha.desktop PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/5761/diff
> 
> 
> Testing
> -------
> 
> Tested the following cases:
> - Create a new archive
> - Add files and/or directories to an archive 
> - Delete files and/or directories from an archive
> - Extract files and/or directories from an archive
> - Preview files from an archive.
> 
> 
> Thanks,
> 
> George
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-utils-devel/attachments/20110717/f053a30d/attachment.htm