<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5703/">http://svn.reviewboard.kde.org/r/5703/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While this is a first step towards fixing that bug report, I do feel that it still needs more work -- for one, this only works for cliinterface-derived plugins (ie. tar archives would still probably have that problem, for example).
The idea of detecting write errors when the programs write then is nice, and to me it sounds like it has more applications than just checking for "disk full" messages.
It would be interesting to check how libarchiveplugin and libsinglefileplugin currently behave under low disk space conditions, and perhaps use kdelibs' KDiskFreeSpaceInfo together with calculating the extracted size when possible to not even start the extraction when the disk will be full. </pre>
<br />
<p>- Raphael</p>
<br />
<p>On November 1st, 2010, 7:47 a.m., George Metaxas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdeutils.</div>
<div>By George Metaxas.</div>
<p style="color: grey;"><i>Updated Nov. 1, 2010, 7:47 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hello!
This patch fixes bug 206383 in ark, where ark cannot handle the situation of a disk becoming full, when using an external extracting utility (rar, unrar, unzip, etc). </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested the code using a file mounted through loop in a local directory, and proceeding to extract into it archives with the following types:
- A rar file
- A 7z file
- A zip file
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=206383">206383</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeutils/ark/kerfuffle/cliinterface.h <span style="color: grey">(1191233)</span></li>
<li>/trunk/KDE/kdeutils/ark/kerfuffle/cliinterface.cpp <span style="color: grey">(1191233)</span></li>
<li>/trunk/KDE/kdeutils/ark/plugins/cli7zplugin/cliplugin.cpp <span style="color: grey">(1191233)</span></li>
<li>/trunk/KDE/kdeutils/ark/plugins/cliplugin/cliplugin.cpp <span style="color: grey">(1191233)</span></li>
<li>/trunk/KDE/kdeutils/ark/plugins/clirarplugin/cliplugin.cpp <span style="color: grey">(1191233)</span></li>
<li>/trunk/KDE/kdeutils/ark/plugins/clizipplugin/cliplugin.cpp <span style="color: grey">(1191233)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5703/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>