Review Request 109255: Allow messages to filter outgoing messages

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109255/#review28440
-----------------------------------------------------------



KTp/message-processor.h
<http://git.reviewboard.kde.org/r/109255/#comment21248>

    "I hope it's a good name"
    
    Simple way to test, ask someone who has not seen the code what they think this method would do.
    
    I don't think this is particularly clear, it sounds like this should be be run before calling processMessage();.
    
    Needs to mention sending or outgoing or something.
    
    
    I don't particularly like the idea of returning a KTp::Message because we only ever use a single string out of it (and returning HTML etc. would be a really bad idea) which makes most of it entirely pointless. I thought we'd discussed that, but I won't force this.


Change the name, then ship it.

- David Edmundson


On March 3, 2013, 5:47 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109255/
> -----------------------------------------------------------
> 
> (Updated March 3, 2013, 5:47 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This is the corresponding patch to https://git.reviewboard.kde.org/r/109254/
> 
> Adds a method to KTp::AbstractMessageFilter called filterOutgoingMessage(), and a method to KTp::MessageProcessor called preprocessMessage().
> Hopefully they're sensible names.
> 
> 
> This addresses bug 304740.
>     http://bugs.kde.org/show_bug.cgi?id=304740
> 
> 
> Diffs
> -----
> 
>   KTp/abstract-message-filter.h dfa7bc6 
>   KTp/abstract-message-filter.cpp acead98 
>   KTp/message-processor.h 7cd4d87 
>   KTp/message-processor.cpp 82b11eb 
>   KTp/message.h 796d5ea 
>   KTp/message.cpp a7bc6c2 
> 
> Diff: http://git.reviewboard.kde.org/r/109255/diff/
> 
> 
> Testing
> -------
> 
> searchexpansion filter worked.
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130303/560d2779/attachment.html>