Review Request 109255: Allow messages to filter outgoing messages

Lasath Fernando kde at lasath.org
Sun Mar 3 20:53:01 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109255/
-----------------------------------------------------------

(Updated March 3, 2013, 8:53 p.m.)


Review request for Telepathy.


Changes
-------

Rename processMessage() and preprocessMessage() to processIncomingMessage() and processOutgoingMessage() respectively.


Description
-------

This is the corresponding patch to https://git.reviewboard.kde.org/r/109254/

Adds a method to KTp::AbstractMessageFilter called filterOutgoingMessage(), and a method to KTp::MessageProcessor called preprocessMessage().
Hopefully they're sensible names.


This addresses bug 304740.
    http://bugs.kde.org/show_bug.cgi?id=304740


Diffs (updated)
-----

  KTp/Declarative/messages-model.cpp 351be0f 
  KTp/abstract-message-filter.h dfa7bc6 
  KTp/message.cpp a7bc6c2 
  KTp/message-processor.cpp 82b11eb 
  KTp/message.h 796d5ea 
  KTp/message-processor.h 7cd4d87 
  KTp/abstract-message-filter.cpp acead98 

Diff: http://git.reviewboard.kde.org/r/109255/diff/


Testing
-------

searchexpansion filter worked.


Thanks,

Lasath Fernando

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130303/50440710/attachment-0001.html>


More information about the KDE-Telepathy mailing list