<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109255/">http://git.reviewboard.kde.org/r/109255/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109255/diff/1/?file=116655#file116655line61" style="color: black; font-weight: bold; text-decoration: underline;">KTp/message-processor.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class KTP_EXPORT MessageProcessor : public QObject</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">61</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KTp</span><span class="o">::</span><span class="n">Message</span> <span class="n">preprocessMessage</span><span class="p">(</span><span class="k">const</span> <span class="n">QString</span> <span class="o">&</span><span class="n">messageText</span><span class="p">,</span> <span class="k">const</span> <span class="n">Tp</span><span class="o">::</span><span class="n">AccountPtr</span> <span class="o">&</span><span class="n">account</span><span class="p">,</span> <span class="k">const</span> <span class="n">Tp</span><span class="o">::</span><span class="n">TextChannelPtr</span> <span class="o">&</span><span class="n">channel</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"I hope it's a good name"
Simple way to test, ask someone who has not seen the code what they think this method would do.
I don't think this is particularly clear, it sounds like this should be be run before calling processMessage();.
Needs to mention sending or outgoing or something.
I don't particularly like the idea of returning a KTp::Message because we only ever use a single string out of it (and returning HTML etc. would be a really bad idea) which makes most of it entirely pointless. I thought we'd discussed that, but I won't force this.</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Change the name, then ship it.</pre>
<p>- David</p>
<br />
<p>On March 3rd, 2013, 5:47 a.m. UTC, Lasath Fernando wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Lasath Fernando.</div>
<p style="color: grey;"><i>Updated March 3, 2013, 5:47 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the corresponding patch to https://git.reviewboard.kde.org/r/109254/
Adds a method to KTp::AbstractMessageFilter called filterOutgoingMessage(), and a method to KTp::MessageProcessor called preprocessMessage().
Hopefully they're sensible names.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">searchexpansion filter worked.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=304740">304740</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KTp/abstract-message-filter.h <span style="color: grey">(dfa7bc6)</span></li>
<li>KTp/abstract-message-filter.cpp <span style="color: grey">(acead98)</span></li>
<li>KTp/message-processor.h <span style="color: grey">(7cd4d87)</span></li>
<li>KTp/message-processor.cpp <span style="color: grey">(82b11eb)</span></li>
<li>KTp/message.h <span style="color: grey">(796d5ea)</span></li>
<li>KTp/message.cpp <span style="color: grey">(a7bc6c2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109255/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>