Review Request: Fix formatting plugin

[Daniele Elmo Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106005/
-----------------------------------------------------------

(Updated Aug. 28, 2012, 3:43 p.m.)


Review request for Telepathy, David Edmundson and Lasath Fernando.


Changes
-------

Fix italics-bold, bold-italics, etc

What is not working is "/-this/-" , that was a test, but is imho wrong... I don't know if it works on gtalk
Also if you add a punctuation mark (for example "_this_, xxxxx", see commented test) it is not working, I don't know how to match a punctuation mark using QRegExp, unless I make a list of them, suggestions?

I did not fix the _italics_ because /italics/ and _underline_ is correct, if GTalk does it wrong I don't see any reason to copy. And btw I don't see any reason for multiple formatting plugins... Eventually we can make it configurable with some presets. But if you really want that, it's just 2 lines to change.


Description
-------

Handle '_' as underlined and '/' as italics, fix the regexp and replacement string and re-enable the formatting plugin


Diffs (updated)
-----

  tests/message-processor-basic-tests.cpp a404908152ef9e21eb7e98cb472775f78c8a4162 
  filters/CMakeLists.txt ee7c23d612cbc737271798344b1939052e1b7326 
  filters/formatting/format-filter.h 4980aff8251a91b2e23de2a7d8257ed25b5d1322 
  filters/formatting/format-filter.cpp 75157fa4b7cd70ad0a1bfdfe7fc8886c37a75ba1 
  tests/message-processor-basic-tests.h 5ffcc92864820d9fd8c535cd4e249cb31310011b 

Diff: http://git.reviewboard.kde.org/r/106005/diff/


Testing
-------

Unit tests included and a few more visual test


Thanks,

Daniele Elmo Domenichelli

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120828/d854f9f8/attachment.html>