Review Request: Fix formatting plugin

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106005/#review17348
-----------------------------------------------------------



filters/formatting/format-filter.cpp
<http://git.reviewboard.kde.org/r/106005/#comment13531>

    No.
    
    This was correct (matching what GTalk does) before even if it is against other conventions.
    
    The whole point of this plugin was to match what GTalk does (and then write another one for what the Facebook web interface does).



filters/formatting/format-filter.cpp
<http://git.reviewboard.kde.org/r/106005/#comment13533>

    Looks very similar to the one I posted on https://bugs.kde.org/show_bug.cgi?id=302534 
    
    Which means it doesn't fix bold italics?
    



tests/message-processor-basic-tests.cpp
<http://git.reviewboard.kde.org/r/106005/#comment13532>

    Why is this commented out? I suspect it's because your new regex now actually breaks this?


- David Edmundson


On Aug. 13, 2012, 10:46 p.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106005/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2012, 10:46 p.m.)
> 
> 
> Review request for Telepathy, David Edmundson and Lasath Fernando.
> 
> 
> Description
> -------
> 
> Handle '_' as underlined and '/' as italics, fix the regexp and replacement string and re-enable the formatting plugin
> 
> 
> Diffs
> -----
> 
>   filters/CMakeLists.txt ee7c23d612cbc737271798344b1939052e1b7326 
>   filters/formatting/format-filter.cpp 75157fa4b7cd70ad0a1bfdfe7fc8886c37a75ba1 
>   tests/message-processor-basic-tests.h 7dc99e4b6e7befc0e3b9eefa3da298083b16aaaf 
>   tests/message-processor-basic-tests.cpp 8546605f923a74585f981f8d6788b16e11a8bd6c 
> 
> Diff: http://git.reviewboard.kde.org/r/106005/diff/
> 
> 
> Testing
> -------
> 
> Unit tests included and a few more visual test
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120813/047facc7/attachment.html>