<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106005/">http://git.reviewboard.kde.org/r/106005/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Telepathy, David Edmundson and Lasath Fernando.</div>
<div>By Daniele Elmo Domenichelli.</div>
<p style="color: grey;"><i>Updated Aug. 28, 2012, 3:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix italics-bold, bold-italics, etc
What is not working is "/-this/-" , that was a test, but is imho wrong... I don't know if it works on gtalk
Also if you add a punctuation mark (for example "_this_, xxxxx", see commented test) it is not working, I don't know how to match a punctuation mark using QRegExp, unless I make a list of them, suggestions?
I did not fix the _italics_ because /italics/ and _underline_ is correct, if GTalk does it wrong I don't see any reason to copy. And btw I don't see any reason for multiple formatting plugins... Eventually we can make it configurable with some presets. But if you really want that, it's just 2 lines to change.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Handle '_' as underlined and '/' as italics, fix the regexp and replacement string and re-enable the formatting plugin
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit tests included and a few more visual test</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/message-processor-basic-tests.cpp <span style="color: grey">(a404908152ef9e21eb7e98cb472775f78c8a4162)</span></li>
<li>filters/CMakeLists.txt <span style="color: grey">(ee7c23d612cbc737271798344b1939052e1b7326)</span></li>
<li>filters/formatting/format-filter.h <span style="color: grey">(4980aff8251a91b2e23de2a7d8257ed25b5d1322)</span></li>
<li>filters/formatting/format-filter.cpp <span style="color: grey">(75157fa4b7cd70ad0a1bfdfe7fc8886c37a75ba1)</span></li>
<li>tests/message-processor-basic-tests.h <span style="color: grey">(5ffcc92864820d9fd8c535cd4e249cb31310011b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106005/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>