Review Request: Fix formatting plugin

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106005/#review18169
-----------------------------------------------------------


> if GTalk does it wrong I don't see any reason to copy.

But the name in the .desktop file is "Google Talk Style Formatting". The idea is so that what you see and send matches what the recipient sees and sends. Therefore we have to match exactly.

It was meant (in the original design) to be on an per-account basis, it probably does need a config with presets though. Lets try and get some sketches of that done.

Anyway, whilst the name remains as it does, they're choice of modifiers is "right", regardless of whether it's right or not.

>I don't know how to match a punctuation mark using QRegEx
[\D\W\S] should match anything that's not a digit, word or space. Though maybe need to invert the logic.






tests/message-processor-basic-tests.cpp
<http://git.reviewboard.kde.org/r/106005/#comment14392>

    You've changed the expected output here, now it's keeping the modifier character. (i.e the *s)
    
    We can't go round changing the tests to match what the code does, that defeats the point of tests.
    


I think we've gone into this with different goals and idea of what should happen. If we go with this, the plugin name _needs_ to change. 
(needs in this case is underlined btw :P )

A bit depends on what Lasath does in the meantime and on his comments.

- David Edmundson


On Aug. 28, 2012, 3:43 p.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106005/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2012, 3:43 p.m.)
> 
> 
> Review request for Telepathy, David Edmundson and Lasath Fernando.
> 
> 
> Description
> -------
> 
> Handle '_' as underlined and '/' as italics, fix the regexp and replacement string and re-enable the formatting plugin
> 
> 
> Diffs
> -----
> 
>   tests/message-processor-basic-tests.cpp a404908152ef9e21eb7e98cb472775f78c8a4162 
>   filters/CMakeLists.txt ee7c23d612cbc737271798344b1939052e1b7326 
>   filters/formatting/format-filter.h 4980aff8251a91b2e23de2a7d8257ed25b5d1322 
>   filters/formatting/format-filter.cpp 75157fa4b7cd70ad0a1bfdfe7fc8886c37a75ba1 
>   tests/message-processor-basic-tests.h 5ffcc92864820d9fd8c535cd4e249cb31310011b 
> 
> Diff: http://git.reviewboard.kde.org/r/106005/diff/
> 
> 
> Testing
> -------
> 
> Unit tests included and a few more visual test
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120828/1186b2b4/attachment.html>