D11508: Fix messagelib core includes

[José Manuel Santamaría Lema]

joselema added a comment.


  In D11508#229863 <https://phabricator.kde.org/D11508#229863>, @mlaurent wrote:
  
  > We don't have this problem in KDE CI...
  
  
  ... because the KDE CI is like Superman, with X-Ray vision. A god made of bits. And of course if a problem isn't 
  catched by the KDE CI, that problem simply doesn't exist.
  
  Now, seriously: we don't have this problem in the KDE CI because the KDE CI isn't checking what Kubuntu's 
  packaging  acc header test is checking. Which is, in case you are missing point, __building the installed headers 
  alone__. This way we can detect problems such as having installed headers relying on other headers which are
  not installed, or are not installed properly or just don't exist. That's not what the KDE CI does, right?
  
  > I will not install not useful class as it's internal.
  > 
  > I don't know why you have this error but we need to find why [...]
  
  You need to find why, I already did and I already told you: 
  " the compilation of 'widgetbase.h' would fail because it won't be able to find '#include <core/enums.h>'"
  
  > Please paste the compile log error (not all just compile error failed)
  
  As I already said above:
  
    In file included from /usr/include/KF5/MessageList/WidgetBase:1:0,
                     from /tmp/ic7YlsVlR2/dump1.h:14:
    /usr/include/KF5/messagelist/widgetbase.h:28:10: fatal error: core/enums.h: No such file or directory
     #include <core/enums.h>
              ^~~~~~~~~~~~~~
    compilation terminated.
  
  
  
  > [...] but not install header which is not necessary.
  
  Right now widgetbase.h is installed. That includes <core/enums.h>, that header is not installed in that path,
  therefore any  external program including widgetbase.h won't be able to build. If that's the case, what's the
  point of installing a header which can't be used?
  
  Maybe you shouldn't install widgetbase.h then?
  If that's the case, the correct patch would be something like:
  
    --- messagelib.orig/messagelist/src/CMakeLists.txt
    +++ messagelib/messagelist/src/CMakeLists.txt
    @@ -94,7 +94,6 @@ ecm_generate_headers(MessageList_Camelca
         View
         Enums
         StorageModelBase
    -    WidgetBase
         REQUIRED_HEADERS MessageList_core_HEADERS
         RELATIVE core
         PREFIX MessageList
  
  Thanks for the review.

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D11508

To: joselema, #kde_pim, #kde_pim_kmail, mlaurent
Cc: mlaurent, joselema, rikmills, dvasin, hrouis, ach, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180320/28d1fc63/attachment.html>