<table><tr><td style="">joselema added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11508">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D11508#229863" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D11508#229863</a>, <a href="https://phabricator.kde.org/p/mlaurent/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@mlaurent</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>We don't have this problem in KDE CI...</p></div>
</blockquote>
<p>... because the KDE CI is like Superman, with X-Ray vision. A god made of bits. And of course if a problem isn't <br />
catched by the KDE CI, that problem simply doesn't exist.</p>
<p>Now, seriously: we don't have this problem in the KDE CI because the KDE CI isn't checking what Kubuntu's <br />
packaging acc header test is checking. Which is, in case you are missing point, <u>building the installed headers <br />
alone</u>. This way we can detect problems such as having installed headers relying on other headers which are<br />
not installed, or are not installed properly or just don't exist. That's not what the KDE CI does, right?</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I will not install not useful class as it's internal.</p>
<p>I don't know why you have this error but we need to find why [...]</p></blockquote>
<p>You need to find why, I already did and I already told you: <br />
" the compilation of 'widgetbase.h' would fail because it won't be able to find '#include <core/enums.h>'"</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Please paste the compile log error (not all just compile error failed)</p></blockquote>
<p>As I already said above:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">In file included from /usr/include/KF5/MessageList/WidgetBase:1:0,
from /tmp/ic7YlsVlR2/dump1.h:14:
/usr/include/KF5/messagelist/widgetbase.h:28:10: fatal error: core/enums.h: No such file or directory
#include <core/enums.h>
^~~~~~~~~~~~~~
compilation terminated.</pre></div>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>[...] but not install header which is not necessary.</p></blockquote>
<p>Right now widgetbase.h is installed. That includes <core/enums.h>, that header is not installed in that path,<br />
therefore any external program including widgetbase.h won't be able to build. If that's the case, what's the<br />
point of installing a header which can't be used?</p>
<p>Maybe you shouldn't install widgetbase.h then?<br />
If that's the case, the correct patch would be something like:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="diff" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #a00000">--- messagelib.orig/messagelist/src/CMakeLists.txt</span>
<span style="color: #00a000">+++ messagelib/messagelist/src/CMakeLists.txt</span>
<span style="color: #800080">@@ -94,7 +94,6 @@ ecm_generate_headers(MessageList_Camelca</span>
View
Enums
StorageModelBase
<span style="color: #a00000">- WidgetBase</span>
REQUIRED_HEADERS MessageList_core_HEADERS
RELATIVE core
PREFIX MessageList</pre></div>
<p>Thanks for the review.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R94 PIM: Message Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11508">https://phabricator.kde.org/D11508</a></div></div><br /><div><strong>To: </strong>joselema, KDE PIM, KDE PIM: KMail, mlaurent<br /><strong>Cc: </strong>mlaurent, joselema, rikmills, dvasin, hrouis, ach, winterz, vkrause, knauss, dvratil<br /></div>