[Differential] [Commented On] D2384: Add key-selection page to AccountWizard

[aheinecke (Andre Heinecke)]

aheinecke added inline comments.

INLINE COMMENTS

> mlaurent wrote in cryptopage.cpp:46
> I already see this code in identitydialog. Is it not possible to create a class in libkleo for it ? to avoid duplicate code ?

I don't think so. The class is a bit misnamed but the main thing the code here does imo is create a backend job and adds error and success handling.

The one thing I see that we could put in libkleo / qgpgme would be API to have a "defaultKeyGenerationJob" that takes name and email as arguments and otherwise used default parameters. So that we have default parameters in a central place and can do the version check what kind of defaults gnupg accepts.

e.g. newer version accept key-type: default key-length: default  etc. and 2.1 even has an --quick-gen-key that only takes name and email and does not need params at all.

> dialog.cpp:62
> +        CryptoPage *cryptoPage = new CryptoPage(this);
> +        addPage(cryptoPage, i18n("Secure your Communication"));
>      }

I think we need to check if GnuPG is installed here, as it's optional for KMail?

An "if (!GpgME::checkEngine(GpgME::OpenPGP))"
....

should do the trick. Otherwise the other jobs will result in errors.

REPOSITORY
  rKDEPIM KDE PIM

REVISION DETAIL
  https://phabricator.kde.org/D2384

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, aheinecke, mlaurent
Cc: kde-pim, spencerb, dvasin, winterz, smartins, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160810/90d6a7ce/attachment.html>