[Differential] [Commented On] D2384: Add key-selection page to AccountWizard

[dvratil (Daniel Vrátil)]

dvratil added inline comments.

INLINE COMMENTS

> aheinecke wrote in cryptopage.cpp:46
> I don't think so. The class is a bit misnamed but the main thing the code here does imo is create a backend job and adds error and success handling.
> 
> The one thing I see that we could put in libkleo / qgpgme would be API to have a "defaultKeyGenerationJob" that takes name and email as arguments and otherwise used default parameters. So that we have default parameters in a central place and can do the version check what kind of defaults gnupg accepts.
> 
> e.g. newer version accept key-type: default key-length: default  etc. and 2.1 even has an --quick-gen-key that only takes name and email and does not need params at all.

Yeah, the overall KeyGenerationJob is a wrapper that wraps key generation + key realoding into a single Kleo::Job that can be bound to the ProgressDialog.

I'd like to hide the XML into a job in libkleo though. Maybe it would even make sense to have a more complex job that allows specifying all kinds of arguments, subkeys etc. and would generate the XML internally.

REPOSITORY
  rKDEPIM KDE PIM

REVISION DETAIL
  https://phabricator.kde.org/D2384

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, aheinecke, mlaurent
Cc: kde-pim, spencerb, dvasin, winterz, smartins, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160810/2439d2cd/attachment.html>