[Differential] [Requested Changes To] D2384: Add key-selection page to AccountWizard

[mlaurent (Laurent Montel)]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> cryptopage.cpp:38
> +
> +#include <QDebug>
> +#include <QFileDialog>

QDebug is not necessary or we need to use accountwizard_debug.h

> cryptopage.cpp:46
> +public:
> +    KeyGenerationJob(const QString &name, const QString &email, Kleo::KeySelectionCombo *parent)
> +        : Kleo::Job(parent)

I already see this code in identitydialog. Is it not possible to create a class in libkleo for it ? to avoid duplicate code ?

REPOSITORY
  rKDEPIM KDE PIM

REVISION DETAIL
  https://phabricator.kde.org/D2384

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, aheinecke, mlaurent
Cc: kde-pim, spencerb, dvasin, winterz, smartins, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20160810/dfc57309/attachment.html>