<table><tr><td style="">aheinecke added inline comments.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2384" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2384#inline-9652" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">mlaurent</span> wrote in <span style="color: #4b4d51; font-weight: bold;">cryptopage.cpp:46</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I already see this code in identitydialog. Is it not possible to create a class in libkleo for it ? to avoid duplicate code ?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't think so. The class is a bit misnamed but the main thing the code here does imo is create a backend job and adds error and success handling.</p>
<p style="padding: 0; margin: 8px;">The one thing I see that we could put in libkleo / qgpgme would be API to have a "defaultKeyGenerationJob" that takes name and email as arguments and otherwise used default parameters. So that we have default parameters in a central place and can do the version check what kind of defaults gnupg accepts.</p>
<p style="padding: 0; margin: 8px;">e.g. newer version accept key-type: default key-length: default etc. and 2.1 even has an --quick-gen-key that only takes name and email and does not need params at all.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2384#inline-9658" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dialog.cpp:62</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">CryptoPage</span> <span style="color: #aa2211">*</span><span class="n">cryptoPage</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">CryptoPage</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span class="n">addPage</span><span class="p">(</span><span class="n">cryptoPage</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Secure your Communication"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think we need to check if GnuPG is installed here, as it's optional for KMail?</p>
<p style="padding: 0; margin: 8px;">An "if (!GpgME::checkEngine(GpgME::OpenPGP))"<br />
....</p>
<p style="padding: 0; margin: 8px;">should do the trick. Otherwise the other jobs will result in errors.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKDEPIM KDE PIM</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2384" rel="noreferrer">https://phabricator.kde.org/D2384</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>dvratil, aheinecke, mlaurent<br /><strong>Cc: </strong>kde-pim, spencerb, dvasin, winterz, smartins, vkrause, mlaurent, knauss, dvratil<br /></div>