[Kde-pim] [PATCH] Change two methods in KPimIdentities

[Thomas McGuire]

Hi,

On Monday 20 August 2007, Ingo Klöcker wrote:
> On Monday 20 August 2007 01:41, Thomas McGuire wrote:
> > Hello,
> >
> > I am asking for permission to change two methods of the Identity
> > class of KPimIdentities. These methods are only used by KMail.
> >
> > [..]
>
> I'm okay with the change, but there are two things we/you will have to
> keep in mind:
>
> a) You will have to provide an upgrade script taking care of adapting
> old configuration files to the changes.
Right, I totally forgot about that. The concept is easy: Look into the 
emailidentities file for the "Transport" property. If this is not already an 
integer, look into the mailtransports file and find the transport ID that 
matches the name.
However, I don't know any python or perl, so I've no idea how to do this. Are 
there update scripts which do something similar? Could I maybe create a 
little KDE app which does that? Or is anybody willing to help me with this?

> b) After this change the X-KMail-Transport header created by older
> versions of KMail will no longer work. This might in particular effect
> templates. I'm not sure what to do about this. One way around this
> problem would be some legacy support code mapping the old transport
> names to the new ids. This code would be removed again in KDE 4.1. At
> most, I propose to use the new header X-KMail-TransportId instead of
> re-using the existing X-KMail-Transport header.
Good idea, I think changing X-KMail-Transport to X-KMail-TransportId and 
adding some legacy support code to KMComposeWin::setMsg() to deal with the 
old X-KMail-Transport field should do the job. I'll look into this.

> I didn't spot any obvious errors in the patch. So feel free to commit
> (but keep the above two points in mind).
Argh, I already committed. Next time I will wait longer. Sorry.

Regards,
Thomas


_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/