[Kde-pim] [PATCH] Change two methods in KPimIdentities

[Ingo Klöcker]

On Monday 20 August 2007 01:41, Thomas McGuire wrote:
> Hello,
>
> I am asking for permission to change two methods of the Identity
> class of KPimIdentities. These methods are only used by KMail.
>
> The rather small patch is attached.
>
> The only thing that changes is that the transport for each identity
> is now stored as an int instead of a string.
>
> This makes sense because the mailtransport library, which was
> recently introduced, uses int IDs as identifiers for the transports.
> Although KMail could use names to identify transports, this would
> make the code more cumbersome in some places. Using IDs is more
> natural.
>
> For reference, I also attached the KMail patch to deal with the
> changes. Note that the patch also gets rid of some cruft which is now
> handled inside mailtransport and fixes a bug or two (and does
> hopefully not introduce more).

I'm okay with the change, but there are two things we/you will have to 
keep in mind:
a) You will have to provide an upgrade script taking care of adapting 
old configuration files to the changes.
b) After this change the X-KMail-Transport header created by older 
versions of KMail will no longer work. This might in particular effect 
templates. I'm not sure what to do about this. One way around this 
problem would be some legacy support code mapping the old transport 
names to the new ids. This code would be removed again in KDE 4.1. At 
most, I propose to use the new header X-KMail-TransportId instead of 
re-using the existing X-KMail-Transport header.

I didn't spot any obvious errors in the patch. So feel free to commit 
(but keep the above two points in mind).


Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20070820/aaaa4768/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/