[Kde-pim] [PATCH] Change two methods in KPimIdentities

[Ingo Klöcker]

On Wednesday 29 August 2007 23:45, Tom Albers wrote:
> Op wo 29 aug 2007 22:00 schreef u:
> > On Monday 20 August 2007, Ingo Klöcker wrote:
> > > On Monday 20 August 2007 01:41, Thomas McGuire wrote:
> > > > Hello,
> > > >
> > > > I am asking for permission to change two methods of the
> > > > Identity class of KPimIdentities. These methods are only used
> > > > by KMail.
> > > >
> > > > The rather small patch is attached.
> > > >
> > > > The only thing that changes is that the transport for each
> > > > identity is now stored as an int instead of a string.
> > >
> > > I'm okay with the change, but there are two things we/you will
> > > have to keep in mind:
> > >
> > > a) You will have to provide an upgrade script taking care of
> > > adapting old configuration files to the changes.
> >
> > I give up on this. As I said, I don't know Perl or Python, so I am
> > unable to write the script.
> > I'll revert everything on next Monday, excluding the port to
> > TransportComboBox and the various fixes in revision 702520.
> >
> > I'll also try to not do any config changes or kdepimlibs SIC/BIC
> > changes anymore until KDE 4.0.
> >
> > For reference, the patches I'll commit on Monday are attached.
> > However, they are more or less only reverts of my previous commit,
> > so they are uninteresting.
>
> I object. ;-)
> Not being able to write the update script isn't serious enough to
> revert to patch. Then KMail has to live without the update script, if
> i understood correctly the id's should already be ints, right?

The transports do already have integer ids, but they are nevertheless 
still referenced by name everywhere (e.g. by the identities and also by 
less important properties like "current transport" and "default 
transport").


Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20070829/29b054e9/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/