D11779: General Code clean-up

[Frederik Schwarzer]

schwarzer added a comment.


  Looks good to me. But wait a few more days in case others want to review as well.

INLINE COMMENTS

> gameselectionscene.cpp:149
>  
> -    void paint( QPainter * painter, const QStyleOptionGraphicsItem * option, QWidget * widget = 0 ) Q_DECL_OVERRIDE
>      {

Just a hint: If you are using "nullptr" (which is good), you could also switch "Q_DECL_OVERRIDE" with "override".

> kcardscene.cpp:85
>  
> -        Q_ASSERT( object == 0 );
>  

The C++ Core Guidelines recommend leaving the comparison in this case, so Q_ASSERT( !object ); would be enough.

REPOSITORY
  R410 KPatience

REVISION DETAIL
  https://phabricator.kde.org/D11779

To: fabiank, #kde_games, aacid
Cc: schwarzer, #kde_games
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20180329/a532a534/attachment.html>