D11779: General Code clean-up

Fabian Kosmale noreply at phabricator.kde.org
Thu Mar 29 13:10:04 UTC 2018


fabiank added inline comments.

INLINE COMMENTS

> schwarzer wrote in gameselectionscene.cpp:149
> Just a hint: If you are using "nullptr" (which is good), you could also switch "Q_DECL_OVERRIDE" with "override".

I was actually wondering about that one: Do we still want to support older compilers? In that case, we should probably go for Q_NULLPTR. If not, I'll also switch Q_DECL_OVERRIDE to override.

REPOSITORY
  R410 KPatience

REVISION DETAIL
  https://phabricator.kde.org/D11779

To: fabiank, #kde_games, aacid
Cc: schwarzer, #kde_games
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20180329/7c60257d/attachment-0001.html>


More information about the kde-games-devel mailing list