<table><tr><td style="">schwarzer added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11779">View Revision</a></tr></table><br /><div><div><p>Looks good to me. But wait a few more days in case others want to review as well.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11779#inline-58716">View Inline</a><span style="color: #4b4d51; font-weight: bold;">gameselectionscene.cpp:149</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">void</span> <span class="n">paint</span><span class="p">(</span> <span class="n">QPainter</span> <span style="color: #aa2211">*</span> <span class="n">painter</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QStyleOptionGraphicsItem</span> <span style="color: #aa2211">*</span> <span class="n">option</span><span class="p">,</span> <span class="n">QWidget</span> <span style="color: #aa2211">*</span> <span class="n">widget</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span> <span class="p">)</span> <span class="n">Q_DECL_OVERRIDE</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">void</span> <span class="n">paint</span><span class="p">(</span> <span class="n">QPainter</span> <span style="color: #aa2211">*</span> <span class="n">painter</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">QStyleOptionGraphicsItem</span> <span style="color: #aa2211">*</span> <span class="n">option</span><span class="p">,</span> <span class="n">QWidget</span> <span style="color: #aa2211">*</span> <span class="n">widget</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">nullptr</span></span> <span class="p">)</span> <span class="n">Q_DECL_OVERRIDE</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Just a hint: If you are using "nullptr" (which is good), you could also switch "Q_DECL_OVERRIDE" with "override".</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11779#inline-58717">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcardscene.cpp:85</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">Q_ASSERT</span><span class="p">(</span> <span class="n">object</span> <span style="color: #aa2211">==</span> <span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">Q_ASSERT</span><span class="p">(</span> <span class="n">object</span> <span style="color: #aa2211">==</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">nullptr</span></span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The C++ Core Guidelines recommend leaving the comparison in this case, so Q_ASSERT( !object ); would be enough.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R410 KPatience</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11779">https://phabricator.kde.org/D11779</a></div></div><br /><div><strong>To: </strong>fabiank, KDE Games, aacid<br /><strong>Cc: </strong>schwarzer, KDE Games<br /></div>