[Kde-games-devel] Review Request 127284: KBlocks: Port sound to KgSound

[Julian Helfferich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127284/
-----------------------------------------------------------

(Updated March 6, 2016, 3:55 a.m.)


Review request for KDE Games.


Changes
-------

Included suggestions from Frederik Schwarzer:

* Use enum class instead of simple enum
* Remove explicit keyword from contructor
* Use switch-case instead of if-else-if-else


Repository: kblocks


Description
-------

Port sound in KBlocksSound from Phonon to KgSound. Note that neither before nor after this port sounds are played (the KBlocksSound::playSound() function is not called). I have also re-enabled the sound and will post the patch here once the port to KgSound is approved and pushed.

The new KBlocksSound uses the sounds from the sounds/ directory. Previously it was intended (at least it seams so to me) that the sound is part of the theme. However, there are only two of three sounds in the themes/ directory (default theme). Thus, unless there are any themed sounds, I suggest to simply use the sounds from the sounds/ directory.


Diffs (updated)
-----

  CMakeLists.txt 38fdfd3 
  KBlocksScene.cpp 07cd457 
  KBlocksSound.h dc02775 
  KBlocksSound.cpp 1346bc6 
  sounds/CMakeLists.txt PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127284/diff/


Testing
-------

The testing were done for this patch plus the next patch enabling the sounds.
 
* Played single game -> Sounds play correctly.
* Played Human vs AI -> Sounds play only for human player (as intended).
* Turned off/on sounds -> Sounds off/on correctly.


Thanks,

Julian Helfferich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160306/18208f2f/attachment.html>