[Kde-games-devel] Review Request 127284: KBlocks: Port sound to KgSound

[Julian Helfferich]

> On March 5, 2016, 6:41 a.m., Frederik Schwarzer wrote:
> > Nice. :)
> > Could you also edit https://community.kde.org/KDE_Games/Porting accordingly after you committed this.

Yes, I will. After it took me 15 minutes to figure out how I can log in, I can do it in no time ;)


> On March 5, 2016, 6:41 a.m., Frederik Schwarzer wrote:
> > KBlocksSound.h, line 21
> > <https://git.reviewboard.kde.org/r/127284/diff/1/?file=448013#file448013line21>
> >
> >     Prefer enum class over older enum type.
> >     Just write "enum class Sound {" and get type-safety for free. :)

Great! I learned something new today :) Type-safety plus I don't need to make the enum a member of the class trying to protect its scope.


> On March 5, 2016, 6:41 a.m., Frederik Schwarzer wrote:
> > KBlocksSound.h, line 28
> > <https://git.reviewboard.kde.org/r/127284/diff/1/?file=448013#file448013line28>
> >
> >     Only constructors which can be called with one parameter should be marked explicit.

True. I also removed the virtual keyword from the destructor.


- Julian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127284/#review93180
-----------------------------------------------------------


On March 6, 2016, 3:55 a.m., Julian Helfferich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127284/
> -----------------------------------------------------------
> 
> (Updated March 6, 2016, 3:55 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: kblocks
> 
> 
> Description
> -------
> 
> Port sound in KBlocksSound from Phonon to KgSound. Note that neither before nor after this port sounds are played (the KBlocksSound::playSound() function is not called). I have also re-enabled the sound and will post the patch here once the port to KgSound is approved and pushed.
> 
> The new KBlocksSound uses the sounds from the sounds/ directory. Previously it was intended (at least it seams so to me) that the sound is part of the theme. However, there are only two of three sounds in the themes/ directory (default theme). Thus, unless there are any themed sounds, I suggest to simply use the sounds from the sounds/ directory.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 38fdfd3 
>   KBlocksScene.cpp 07cd457 
>   KBlocksSound.h dc02775 
>   KBlocksSound.cpp 1346bc6 
>   sounds/CMakeLists.txt PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127284/diff/
> 
> 
> Testing
> -------
> 
> The testing were done for this patch plus the next patch enabling the sounds.
>  
> * Played single game -> Sounds play correctly.
> * Played Human vs AI -> Sounds play only for human player (as intended).
> * Turned off/on sounds -> Sounds off/on correctly.
> 
> 
> Thanks,
> 
> Julian Helfferich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160306/19697c27/attachment.html>