[Kde-games-devel] Review Request 113864: do not crash closing knavalbattle in the middle of an animation

[Jaime]

The patch is pushed,


2013/11/21 Jaime Torres Amate <jtamate at gmail.com>

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113864/
>
> On November 20th, 2013, 11:29 p.m. UTC, *Albert Astals Cid* wrote:
>
> I think a better solution would be making the animator not a pure singleton but something that gets created and deleted by the window and then just deleting the animator on the window deletion, but that's a big rework, so yeah just commit this and then maybe work on the rework if you have time/stamina?
>
>  On November 20th, 2013, 11:30 p.m. UTC, *Albert Astals Cid* wrote:
>
> branches 4.11 and up, no?
>
>  Yes. Tonight (or tomorrow) it will be pushed to 4.11, 4.12 and master. Including your comment for a better solution (just in case).
>
>
> - Jaime Torres
>
> On November 14th, 2013, 4:05 p.m. UTC, Jaime Torres Amate wrote:
>   Review request for KDE Games and Roney Gomes.
> By Jaime Torres Amate.
>
> *Updated Nov. 14, 2013, 4:05 p.m.*
>  *Bugs: * 325126 <http://bugs.kde.org/show_bug.cgi?id=325126>
>  *Repository: * knavalbattle
> Description
>
> stop the animation when the main window is about to be closed.
>
>   Testing
>
> I was able to reproduce the crash easily, now I can't.
>
>   Diffs
>
>    - src/mainwindow.h (dbac1f9)
>    - src/mainwindow.cpp (e3f2a35)
>
> View Diff <http://git.reviewboard.kde.org/r/113864/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131121/5a3ca70e/attachment.html>