<div dir="ltr">The patch is pushed,<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/11/21 Jaime Torres Amate <span dir="ltr"><<a href="mailto:jtamate@gmail.com" target="_blank">jtamate@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div class="im">
<table style="border:1px #c9c399 solid" bgcolor="#f9f3c9" cellpadding="8" width="100%">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113864/" target="_blank">http://git.reviewboard.kde.org/r/113864/</a>
</td>
</tr>
</tbody></table>
<br>
</div><blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px"><div class="im">
<p style="margin-top:0">On November 20th, 2013, 11:29 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
</div><div class="im"><blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">I think a better solution would be making the animator not a pure singleton but something that gets created and deleted by the window and then just deleting the animator on the window deletion, but that's a big rework, so yeah just commit this and then maybe work on the rework if you have time/stamina?</pre>
</blockquote>
</div><div class="im"><p>On November 20th, 2013, 11:30 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">branches 4.11 and up, no?</pre>
</blockquote>
</div></blockquote>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Yes. Tonight (or tomorrow) it will be pushed to 4.11, 4.12 and master. Including your comment for a better solution (just in case). </pre>
<span class="HOEnZb"><font color="#888888">
<br>
<p>- Jaime Torres</p></font></span><div class="im">
<br>
<p>On November 14th, 2013, 4:05 p.m. UTC, Jaime Torres Amate wrote:</p>
<table style="background-image:url('');background-repeat:repeat-x;border:1px black solid" bgcolor="#fefadf" cellpadding="8" cellspacing="0" width="100%">
<tbody><tr>
<td>
<div>Review request for KDE Games and Roney Gomes.</div>
<div>By Jaime Torres Amate.</div>
<p style="color:grey"><i>Updated Nov. 14, 2013, 4:05 p.m.</i></p>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt;margin-top:1.5em">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=325126" target="_blank">325126</a>
</div>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
knavalbattle
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" width="100%">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">stop the animation when the main window is about to be closed.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" width="100%">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">I was able to reproduce the crash easily, now I can't.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>src/mainwindow.h <span style="color:grey">(dbac1f9)</span></li>
<li>src/mainwindow.cpp <span style="color:grey">(e3f2a35)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113864/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div></div>
</div>
</blockquote></div><br></div>