[Kde-games-devel] Review Request 113782: Make "current standings" dialogue a dockable widget.

[Alexander Schuch]

> On Nov. 16, 2013, 4:21 p.m., Nemanja Hirsl wrote:
> > mainwin.cc, line 140
> > <http://git.reviewboard.kde.org/r/113782/diff/2/?file=214390#file214390line140>
> >
> >     Just an idea: 
> >     I don't see it is natural to have horizontal table "squeezed" on the right side, maybe to put it at the bottom together with messages?

I put it as a tab to the bottom area by default.

My personal setup is to move both docks to the right. I have a 16:9 screen resolution and the Konquest board is squared, so I naturally have "unused" space at the right edge. But for a default position, bottom is fine.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113782/#review43827
-----------------------------------------------------------


On Nov. 16, 2013, 5:58 a.m., Alexander Schuch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113782/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2013, 5:58 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> The dialogue "current standings" is replaced by a dockable widget. This way the player is able to see the standings all the time without the need to open/close the dialogue at the beginning of each turn.
> 
> The dockable widget can also be made floating, so it can be used almost the same as the modal dialogue before.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3b321ad 
>   dialogs/scoredlg.h bda18a5 
>   dialogs/scoredlg.cc 5e66cd4 
>   gameview.h 7d8700e 
>   gameview.cc f67d570 
>   konquestui.rc 683cd11 
>   mainwin.h 663177b 
>   mainwin.cc 2b4cece 
>   view/standingswidget.h PRE-CREATION 
>   view/standingswidget.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113782/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Schuch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131117/e908a03a/attachment.html>