[Kde-games-devel] Review Request 113782: Make "current standings" dialogue a dockable widget.
Nemanja Hirsl
nemhirsl at gmail.com
Sat Nov 16 16:21:44 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113782/#review43827
-----------------------------------------------------------
mainwin.cc
<http://git.reviewboard.kde.org/r/113782/#comment31463>
Just an idea:
I don't see it is natural to have horizontal table "squeezed" on the right side, maybe to put it at the bottom together with messages?
- Nemanja Hirsl
On Nov. 16, 2013, 5:58 a.m., Alexander Schuch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113782/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2013, 5:58 a.m.)
>
>
> Review request for KDE Games.
>
>
> Repository: konquest
>
>
> Description
> -------
>
> The dialogue "current standings" is replaced by a dockable widget. This way the player is able to see the standings all the time without the need to open/close the dialogue at the beginning of each turn.
>
> The dockable widget can also be made floating, so it can be used almost the same as the modal dialogue before.
>
>
> Diffs
> -----
>
> CMakeLists.txt 3b321ad
> dialogs/scoredlg.h bda18a5
> dialogs/scoredlg.cc 5e66cd4
> gameview.h 7d8700e
> gameview.cc f67d570
> konquestui.rc 683cd11
> mainwin.h 663177b
> mainwin.cc 2b4cece
> view/standingswidget.h PRE-CREATION
> view/standingswidget.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/113782/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Schuch
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131116/403a655c/attachment-0001.html>
More information about the kde-games-devel
mailing list