<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113782/">http://git.reviewboard.kde.org/r/113782/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 16th, 2013, 4:21 p.m. UTC, <b>Nemanja Hirsl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113782/diff/2/?file=214390#file214390line140" style="color: black; font-weight: bold; text-decoration: underline;">mainwin.cc</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">MainWindow::setupActions()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">134</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">addDockWidget</span><span class="p">(</span><span class="n">Qt</span><span class="o">::</span><span class="n">RightDockWidgetArea</span><span class="p">,</span> <span class="n">m_standingsDock</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just an idea:
I don't see it is natural to have horizontal table "squeezed" on the right side, maybe to put it at the bottom together with messages?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I put it as a tab to the bottom area by default.
My personal setup is to move both docks to the right. I have a 16:9 screen resolution and the Konquest board is squared, so I naturally have "unused" space at the right edge. But for a default position, bottom is fine.</pre>
<br />
<p>- Alexander</p>
<br />
<p>On November 16th, 2013, 5:58 a.m. UTC, Alexander Schuch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Alexander Schuch.</div>
<p style="color: grey;"><i>Updated Nov. 16, 2013, 5:58 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konquest
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The dialogue "current standings" is replaced by a dockable widget. This way the player is able to see the standings all the time without the need to open/close the dialogue at the beginning of each turn.
The dockable widget can also be made floating, so it can be used almost the same as the modal dialogue before.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(3b321ad)</span></li>
<li>dialogs/scoredlg.h <span style="color: grey">(bda18a5)</span></li>
<li>dialogs/scoredlg.cc <span style="color: grey">(5e66cd4)</span></li>
<li>gameview.h <span style="color: grey">(7d8700e)</span></li>
<li>gameview.cc <span style="color: grey">(f67d570)</span></li>
<li>konquestui.rc <span style="color: grey">(683cd11)</span></li>
<li>mainwin.h <span style="color: grey">(663177b)</span></li>
<li>mainwin.cc <span style="color: grey">(2b4cece)</span></li>
<li>view/standingswidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>view/standingswidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113782/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>