[Kde-games-devel] Review Request 113782: Make "current standings" dialogue a dockable widget.

Alexander Schuch aschuch247 at gmail.com
Sun Nov 17 18:56:41 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113782/
-----------------------------------------------------------

(Updated Nov. 17, 2013, 6:56 p.m.)


Review request for KDE Games.


Changes
-------

- Remove unused code for current standings dialogue.
- Current standings dock is added as tab to the bottom edge by default (instead of to the right edge).
- Modal final standings dialogue closes messages dock and current standings dock.


Repository: konquest


Description
-------

The dialogue "current standings" is replaced by a dockable widget. This way the player is able to see the standings all the time without the need to open/close the dialogue at the beginning of each turn.

The dockable widget can also be made floating, so it can be used almost the same as the modal dialogue before.


Diffs (updated)
-----

  CMakeLists.txt 3b321ad 
  dialogs/scoredlg.h bda18a5 
  dialogs/scoredlg.cc 5e66cd4 
  gameview.h 7d8700e 
  gameview.cc f67d570 
  konquestui.rc 683cd11 
  mainwin.h 663177b 
  mainwin.cc 2b4cece 
  view/standingswidget.h PRE-CREATION 
  view/standingswidget.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/113782/diff/


Testing
-------


Thanks,

Alexander Schuch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131117/3e0d8f2d/attachment.html>


More information about the kde-games-devel mailing list