[Kde-games-devel] Review Request: add option to allow adjacent ships

[Jaime Torres Amate]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106772/
-----------------------------------------------------------

(Updated Oct. 11, 2012, 8:15 a.m.)


Review request for KDE Games.


Changes
-------

Changed the default, as Albert rightly said.

The AI seems to follow the game settings, but it is not enforced in any way in a network game.

I'm not sure if the setting change should be allowed in the middle of the placement (restart the placement?), or in the middle of a game (no effect).

If this is the case, I can remove the mainwindow.cpp patch, and just keep the checkings, until a better patch is produced.


Description
-------

Add the option to allow adjacent ships.
When it is not checked, the ships can not be placed adjacent.


This addresses bug 168659.
    http://bugs.kde.org/show_bug.cgi?id=168659


Diffs (updated)
-----

  src/battlefield.cpp 32aa525 
  src/kbattleship.kcfg b615f30 
  src/kbattleshipui.rc 7c51ac6 
  src/mainwindow.cpp a7cceeb 
  src/playfield.h 56934dc 
  src/playfield.cpp 61c0ac6 
  src/ship.h 5e35f1a 
  src/ship.cpp 86858d9 

Diff: http://git.reviewboard.kde.org/r/106772/diff/


Testing
-------

tested locally.


Thanks,

Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121011/f4be3771/attachment.html>