[Kde-games-devel] Review Request: add option to allow adjacent ships

[Roney Gomes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106772/#review20234
-----------------------------------------------------------


Hello Jaime.

I've applied your patch and did some tests, here go my conclusions:

1. A player is allowed to change the current rule at any time, which allows the player to, let's say, cheat at will. I think that this rule should be chosen before each game, and could be changed only when the current game is over.

2. In a network game, players can play under different rules. One possible way to solve this would be to add a QCheckBox in the dialog which appears when a player decides to host a new game. This way the host would decide whether the match will be given under the new rule or not.

My idea, aiming to make the user experience consistent through both game modes, is:

a) Prompt a dialog to the user before a single player match. In this dialog he/she would change his/her nickname, set the AI difficulty and the rule to player under.

b) Prompt a dialog to the user before a network match, in order to let him set his/her nickname, the port to make the connection and the game rule.

Notice that in "a" we are going to make the status bar useless, since it's only feature is to change the AI level. So, if we are really going to add this new feature, which is very likely, some redesign is required and the network issue definitely have to be solved. 

These are my opinions. If you have a different approach to the issues pointed above, let me know about it.

Best regards.

- Roney Gomes


On Oct. 11, 2012, 8:15 a.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106772/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2012, 8:15 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Add the option to allow adjacent ships.
> When it is not checked, the ships can not be placed adjacent.
> 
> 
> This addresses bug 168659.
>     http://bugs.kde.org/show_bug.cgi?id=168659
> 
> 
> Diffs
> -----
> 
>   src/battlefield.cpp 32aa525 
>   src/kbattleship.kcfg b615f30 
>   src/kbattleshipui.rc 7c51ac6 
>   src/mainwindow.cpp a7cceeb 
>   src/playfield.h 56934dc 
>   src/playfield.cpp 61c0ac6 
>   src/ship.h 5e35f1a 
>   src/ship.cpp 86858d9 
> 
> Diff: http://git.reviewboard.kde.org/r/106772/diff/
> 
> 
> Testing
> -------
> 
> tested locally.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121012/e9d8025a/attachment.html>