[Kde-games-devel] Review Request: add option to allow adjacent ships

[Albert Astals Cid]

> On Oct. 8, 2012, 9:42 p.m., Roney Gomes wrote:
> > Hello Jaime, thanks for your help on this "bug".
> > 
> > Unluckily, until the end of this week I'll be extremely busy with academic stuff, thus I don't have time to test your patch properly. I don't even have compiled KNavalBattle since the move to git, so I still need to set up my environment properly. :-)
> > 
> > At a first glance your code looks good but, since it is not really solving a bug but adding a new feature instead, the other devs must agree about it.
> > 
> > Though I'm KNavalBattle's current maintainer, I'm not in the position of arbitrarily taking decisions about adding features to the game. My opinion is that your patch is a good improvement and it makes the game more versatile, so I don't see any problems about it. Let's see what the other guys think.
> > 
> > Best regards.

If you like it, you decided already :-)


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106772/#review20103
-----------------------------------------------------------


On Oct. 8, 2012, 5:58 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106772/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2012, 5:58 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Add the option to allow adjacent ships.
> When it is not checked, the ships can not be placed adjacent.
> 
> 
> This addresses bug 168659.
>     http://bugs.kde.org/show_bug.cgi?id=168659
> 
> 
> Diffs
> -----
> 
>   src/battlefield.cpp 32aa525 
>   src/kbattleship.kcfg b615f30 
>   src/kbattleshipui.rc 7c51ac6 
>   src/mainwindow.cpp a7cceeb 
>   src/playfield.h 56934dc 
>   src/playfield.cpp 61c0ac6 
>   src/ship.h 5e35f1a 
>   src/ship.cpp 86858d9 
> 
> Diff: http://git.reviewboard.kde.org/r/106772/diff/
> 
> 
> Testing
> -------
> 
> tested locally.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121010/99a61cb3/attachment.html>