[Kde-games-devel] Review Request: Don't crash if changing KillPercentage/Production with no planet selected.

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/7006/#review10875
-----------------------------------------------------------


True, it fixes the crashes, but i think it would be cooler if you fixed in a different way.

Let me explain myself,

right now you get the new game dialog and there is no selected planet in the minimap, thus it makes no sense to be able of doing anything with the three values under the map, I think it would make more sense if
a) One of the planets was selected (this would solve the crash without need for your code)
b) The three values under the map where disabled (setEnabled(false)) (this would solve the crash without need for your code too)

What do you think?

- Albert Astals Cid


On July 10, 2012, 12:08 a.m., Michael Reeves wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/7006/
> -----------------------------------------------------------
> 
> (Updated July 10, 2012, 12:08 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Checks m_w->map->hasSelection() before determining the selected sector. Avoids calling selected->hasPlanet() on a null pointer. The bug report is for the KillPercentage half of this.
> 
> 
> This addresses bug 297748.
>     https://bugs.kde.org/show_bug.cgi?id=297748
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.8/kdegames/konquest/dialogs/newgamedlg.cc 1304945 
> 
> Diff: http://svn.reviewboard.kde.org/r/7006/diff/
> 
> 
> Testing
> -------
> 
> Verfied that changing KillPercentage/Production works as expected after the patch. Confirmed that crash does not happen with patch.
> 
> 
> Thanks,
> 
> Michael Reeves
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120711/c3baa711/attachment.html>