<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/7006/">http://svn.reviewboard.kde.org/r/7006/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">True, it fixes the crashes, but i think it would be cooler if you fixed in a different way.
Let me explain myself,
right now you get the new game dialog and there is no selected planet in the minimap, thus it makes no sense to be able of doing anything with the three values under the map, I think it would make more sense if
a) One of the planets was selected (this would solve the crash without need for your code)
b) The three values under the map where disabled (setEnabled(false)) (this would solve the crash without need for your code too)
What do you think?</pre>
<br />
<p>- Albert</p>
<br />
<p>On July 10th, 2012, 12:08 a.m., Michael Reeves wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Michael Reeves.</div>
<p style="color: grey;"><i>Updated July 10, 2012, 12:08 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Checks m_w->map->hasSelection() before determining the selected sector. Avoids calling selected->hasPlanet() on a null pointer. The bug report is for the KillPercentage half of this.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Verfied that changing KillPercentage/Production works as expected after the patch. Confirmed that crash does not happen with patch.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=297748">297748</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/KDE/4.8/kdegames/konquest/dialogs/newgamedlg.cc <span style="color: grey">(1304945)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/7006/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>