[Kde-games-devel] Review Request: Don't crash if changing KillPercentage/Production with no planet selected.

[Michael Reeves]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/7006/
-----------------------------------------------------------

(Updated July 12, 2012, 2:31 a.m.)


Review request for KDE Games.


Changes
-------

Disable  KillPercentage/Production if there is no selection.


Description
-------

Checks m_w->map->hasSelection() before determining the selected sector. Avoids calling selected->hasPlanet() on a null pointer. The bug report is for the KillPercentage half of this.


This addresses bug 297748.
    https://bugs.kde.org/show_bug.cgi?id=297748


Diffs (updated)
-----

  /branches/KDE/4.8/kdegames/konquest/dialogs/newgamedlg.cc 1304945 

Diff: http://svn.reviewboard.kde.org/r/7006/diff/


Testing
-------

Verfied that changing KillPercentage/Production works as expected after the patch. Confirmed that crash does not happen with patch.


Thanks,

Michael Reeves

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120712/cf216a34/attachment-0001.html>