[Kde-games-devel] Review Request: Konquest: Implement standing orders

[Pierre Ducroquet]

> On Sept. 13, 2011, 7:19 p.m., Stefan Majewsky wrote:
> > Because standing orders are only executed at the end of the turn, I would like to have an indication in the planet tooltip how much ships would be sent out by these standing orders. Other than that, the interface looks fine. Have not read the code yet.

I have got lots of change pending for konquest trunk that rework the whole game logic (I'm gonna merge them soon, I just need to polish them).
It should be possible to keep most of your patch, except the gamelogic part…


- Pierre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6805/#review10413
-----------------------------------------------------------


On Sept. 13, 2011, 6:58 p.m., Jeffrey Kelling wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6805/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2011, 6:58 p.m.)
> 
> 
> Review request for KDE Games and Pierre Ducroquet.
> 
> 
> Summary
> -------
> 
> This patch implements standing orders, i.e. orders that are repeated each turn if possible. Standing orders are issued the same way as normal order, additionally the added check box has to be checked. They are also removed the same way as normal orders (in the fleet overview). The orders are executed at the end of turn if enough ships are available, if not a message is issued. If the Planet is no longer under the players control the order is deleted. 
> 
> 
> This addresses bug 87882.
>     https://bugs.kde.org/show_bug.cgi?id=87882
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/konquest/fleet.h 1253268 
>   trunk/KDE/kdegames/konquest/fleet.cc 1253268 
>   trunk/KDE/kdegames/konquest/fleetdlg.cc 1253268 
>   trunk/KDE/kdegames/konquest/gamelogic.cc 1253268 
>   trunk/KDE/kdegames/konquest/gameview.h 1253268 
>   trunk/KDE/kdegames/konquest/gameview.cc 1253268 
>   trunk/KDE/kdegames/konquest/player.h 1253268 
>   trunk/KDE/kdegames/konquest/player.cc 1253268 
> 
> Diff: http://svn.reviewboard.kde.org/r/6805/diff
> 
> 
> Testing
> -------
> 
> Played the game, issued standing orders, ...
> 
> 
> Screenshots
> -----------
> 
> Spawn Fleet
>   http://svn.reviewboard.kde.org/r/6805/s/621/
> Fleet Overview
>   http://svn.reviewboard.kde.org/r/6805/s/622/
> 
> 
> Thanks,
> 
> Jeffrey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20110913/165dbabc/attachment.html>