<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6805/">http://svn.reviewboard.kde.org/r/6805/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 13th, 2011, 7:19 p.m., <b>Stefan Majewsky</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Because standing orders are only executed at the end of the turn, I would like to have an indication in the planet tooltip how much ships would be sent out by these standing orders. Other than that, the interface looks fine. Have not read the code yet.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have got lots of change pending for konquest trunk that rework the whole game logic (I'm gonna merge them soon, I just need to polish them).
It should be possible to keep most of your patch, except the gamelogic part…</pre>
<br />
<p>- Pierre</p>
<br />
<p>On September 13th, 2011, 6:58 p.m., Jeffrey Kelling wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games and Pierre Ducroquet.</div>
<div>By Jeffrey Kelling.</div>
<p style="color: grey;"><i>Updated Sept. 13, 2011, 6:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch implements standing orders, i.e. orders that are repeated each turn if possible. Standing orders are issued the same way as normal order, additionally the added check box has to be checked. They are also removed the same way as normal orders (in the fleet overview). The orders are executed at the end of turn if enough ships are available, if not a message is issued. If the Planet is no longer under the players control the order is deleted. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Played the game, issued standing orders, ...</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=87882">87882</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdegames/konquest/fleet.h <span style="color: grey">(1253268)</span></li>
<li>trunk/KDE/kdegames/konquest/fleet.cc <span style="color: grey">(1253268)</span></li>
<li>trunk/KDE/kdegames/konquest/fleetdlg.cc <span style="color: grey">(1253268)</span></li>
<li>trunk/KDE/kdegames/konquest/gamelogic.cc <span style="color: grey">(1253268)</span></li>
<li>trunk/KDE/kdegames/konquest/gameview.h <span style="color: grey">(1253268)</span></li>
<li>trunk/KDE/kdegames/konquest/gameview.cc <span style="color: grey">(1253268)</span></li>
<li>trunk/KDE/kdegames/konquest/player.h <span style="color: grey">(1253268)</span></li>
<li>trunk/KDE/kdegames/konquest/player.cc <span style="color: grey">(1253268)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6805/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/6805/s/621/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2011/09/13/standingOrders_400x100.png" style="border: 1px black solid;" alt="Spawn Fleet" /></a>
<a href="http://svn.reviewboard.kde.org/r/6805/s/622/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2011/09/13/standingOrdersFleetOverView_400x100.png" style="border: 1px black solid;" alt="Fleet Overview" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>