[Kde-games-devel] Review Request: Konquest: Implement standing orders

[Stefan Majewsky]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6805/#review10414
-----------------------------------------------------------



trunk/KDE/kdegames/konquest/fleetdlg.cc
<http://svn.reviewboard.kde.org/r/6805/#comment12224>

    Don't know why the others didn't, but you should include a year in the copyright line.



trunk/KDE/kdegames/konquest/fleetdlg.cc
<http://svn.reviewboard.kde.org/r/6805/#comment12225>

    s/Order/order/g if I'm not mistaken



trunk/KDE/kdegames/konquest/gamelogic.cc
<http://svn.reviewboard.kde.org/r/6805/#comment12226>

    Could use some comments.



trunk/KDE/kdegames/konquest/gameview.cc
<http://svn.reviewboard.kde.org/r/6805/#comment12227>

    Indentation.



trunk/KDE/kdegames/konquest/player.cc
<http://svn.reviewboard.kde.org/r/6805/#comment12228>

    Please remove before committing.


- Stefan


On Sept. 13, 2011, 6:58 p.m., Jeffrey Kelling wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6805/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2011, 6:58 p.m.)
> 
> 
> Review request for KDE Games and Pierre Ducroquet.
> 
> 
> Summary
> -------
> 
> This patch implements standing orders, i.e. orders that are repeated each turn if possible. Standing orders are issued the same way as normal order, additionally the added check box has to be checked. They are also removed the same way as normal orders (in the fleet overview). The orders are executed at the end of turn if enough ships are available, if not a message is issued. If the Planet is no longer under the players control the order is deleted. 
> 
> 
> This addresses bug 87882.
>     https://bugs.kde.org/show_bug.cgi?id=87882
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/konquest/fleet.h 1253268 
>   trunk/KDE/kdegames/konquest/fleet.cc 1253268 
>   trunk/KDE/kdegames/konquest/fleetdlg.cc 1253268 
>   trunk/KDE/kdegames/konquest/gamelogic.cc 1253268 
>   trunk/KDE/kdegames/konquest/gameview.h 1253268 
>   trunk/KDE/kdegames/konquest/gameview.cc 1253268 
>   trunk/KDE/kdegames/konquest/player.h 1253268 
>   trunk/KDE/kdegames/konquest/player.cc 1253268 
> 
> Diff: http://svn.reviewboard.kde.org/r/6805/diff
> 
> 
> Testing
> -------
> 
> Played the game, issued standing orders, ...
> 
> 
> Screenshots
> -----------
> 
> Spawn Fleet
>   http://svn.reviewboard.kde.org/r/6805/s/621/
> Fleet Overview
>   http://svn.reviewboard.kde.org/r/6805/s/622/
> 
> 
> Thanks,
> 
> Jeffrey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20110913/957d82d6/attachment-0001.html>