D13627: [KIconThemes] Isolate private data from race conditions

[David Edmundson]

davidedmundson added a comment.


  > It looks like to KIconLoader::loadIcon is called from multiple threads, but i'm not sure
  
  It's important to know a bug before trying to fix the bug, otherwise you can't know what to fix.
  
  Plasma::IconItem definitely does things in the main thread. That's the one we use in the taskmanager.
  Also worth noting QIcon::fromTheme itself isn't thread safe, so if we did use it from multiple threads you'd have crashes anyway.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D13627

To: anthonyfieroni, davidedmundson, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180620/d7960f08/attachment-0001.html>