<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13627">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>It looks like to KIconLoader::loadIcon is called from multiple threads, but i'm not sure</p></blockquote>
<p>It's important to know a bug before trying to fix the bug, otherwise you can't know what to fix.</p>
<p>Plasma::IconItem definitely does things in the main thread. That's the one we use in the taskmanager.<br />
Also worth noting QIcon::fromTheme itself isn't thread safe, so if we did use it from multiple threads you'd have crashes anyway.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R302 KIconThemes</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13627">https://phabricator.kde.org/D13627</a></div></div><br /><div><strong>To: </strong>anthonyfieroni, davidedmundson, dfaure, Frameworks<br /><strong>Cc: </strong>kde-frameworks-devel, michaelh, ngraham, bruns<br /></div>