D13627: [KIconThemes] Isolate private data from race conditions

[Anthony Fieroni]

anthonyfieroni created this revision.
anthonyfieroni added reviewers: davidedmundson, dfaure, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
anthonyfieroni requested review of this revision.

REVISION SUMMARY
  This problems persist from while a go, i'm not sure to date, but QML engine and/or engine to load icons do it on multiple threads. This result in invalid icons when cache is invalidated.

TEST PLAN
  1. Start plasmashell
  2. Start grouped task (2 or more same instances of app grouped in task manager)
  3. Invalidate icon cache somehow (i update from Qt 5.11.0 to Qt 5.11.1)
  4. Hover grouped task result in all icons to be broken (read some memory chunks)
  
  It looks like to KIconLoader::loadIcon is called from multiple threads, but i'm not sure, since i'm not read it on Qt sources or docs.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D13627

AFFECTED FILES
  src/kiconloader.cpp

To: anthonyfieroni, davidedmundson, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20180620/04f89db4/attachment.html>