Review Request 128249: Add switch to disable KParts' handling of window titles

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128249/#review96773
-----------------------------------------------------------



Would it be better to just have a setter and a member bool for this? It's unlikely that we need some calls to set the title and some to not set it, so this way the setting is set once and for all (and the purpose of the bool is readable from the method name) - and this typically scales better than methods with many args.

- David Faure


On June 19, 2016, 12:35 p.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128249/
> -----------------------------------------------------------
> 
> (Updated June 19, 2016, 12:35 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Kevin Funk.
> 
> 
> Repository: kparts
> 
> 
> Description
> -------
> 
> Applications that use several KParts, like KDevelop, want to do the
> window title settings themselves. To enable that without causing a
> flickering of the KParts' title and the application's title, an
> explicit switch is required, since simply removing the setWindowTitle
> connection after executing a KParts::MainWindow::createGUI(...) call still
> causes an initial flickering, when the GUIActivateEvent is sent in
> the createGUI method. Sending such an event should stay in the createGUI
> method, though.
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.h 61a92e32e638c187253ba9e2cf0d8a410e9966af 
>   src/mainwindow.cpp be0b7ddc637d509f4c8191134096e365616ab38a 
> 
> Diff: https://git.reviewboard.kde.org/r/128249/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160621/6650bc9f/attachment.html>